Initial implementation of proper TLS MAC handling#360
Open
ColtonWilley wants to merge 3 commits intomasterfrom
Open
Initial implementation of proper TLS MAC handling#360ColtonWilley wants to merge 3 commits intomasterfrom
ColtonWilley wants to merge 3 commits intomasterfrom
Conversation
SparkiDev
requested changes
Feb 12, 2026
padelsbach
reviewed
Feb 17, 2026
| */ | ||
| static void wp_aes_block_freectx(wp_AesBlockCtx *ctx) | ||
| { | ||
| if (ctx->tlsmacAlloced) { |
Contributor
There was a problem hiding this comment.
Can we use ->tlsmac != NULL instead, or does the tlsmacAlloced add something?
| XMEMCPY(dst, src, sizeof(*src)); | ||
| /* Deep-copy tlsmac to avoid double-free between src and dst. */ | ||
| if (src->tlsmacAlloced && src->tlsmac != NULL) { | ||
| dst->tlsmac = OPENSSL_malloc(src->tlsmacsize); |
Contributor
There was a problem hiding this comment.
Should tlsmacAlloced be set following this allocation?
| size_t good; | ||
| size_t i, j; | ||
| size_t macSize = ctx->tlsmacsize; | ||
|
|
Contributor
There was a problem hiding this comment.
I realize this is a CT function, but WOLFPROV_ENTER and WOLFPROV_EXIT could be helpful logs here (and are not dependent on crypto status)
SparkiDev
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing handling for OSSL_CIPHER_PARAM_TLS_MAC leads to a mac verify failure when using CBC-MAC. Implement proper handling similar to openssl.